[pacman-dev] [PATCH] libmakepkg: fix linting arrays of empty strings

Morgan Adamiec morganamilo at gmail.com
Sun Oct 21 12:23:07 UTC 2018


On Sun, 21 Oct 2018 at 13:10, Allan McRae <allan at archlinux.org> wrote:
>
> On 21/10/18 9:56 pm, Morgan Adamiec wrote:
> > On Sun, 21 Oct 2018 at 10:16, Allan McRae <allan at archlinux.org> wrote:
> >> The error this gives is:
> >> ==> ERROR: depends is not allowed to be empty.
> >
> > Where so you get this error?
> >
> > pkgname=foo
> > pkgver=1
> > pkgrel=1
> > arch=(any)
> > depends=('')
> >
> > This pkgbuild manages to pass linting for me without this patch.
> >
> > (resend, accidentally sent off list)
> > .
>
> I meant that is the error you get after this patch.  And you can get it
> without the patch using:
>
> depends=('glibc' '' 'gcc')
>
> It is not correct to say depends is empty, or that it can't be empty.
> It can have an empty entry.  As I said, existing issue, not caused by
> your patch - I just noticed it while testing.
>
> A

Ah right, sorry misunderstood. How about we change the type we pass to
lint_one_pkgname() from depends/provides/... to a depend/a provide/...?

This gives "==> ERROR: a depend is not allowed to be empty."


More information about the pacman-dev mailing list