[pacman-dev] [PATCH 2/2] repo-add: print the name of the database when extracting

Eli Schwartz eschwartz at archlinux.org
Wed Oct 31 17:12:34 UTC 2018


Currently this prints the following message:
==> Extracting database to a temporary location...
==> Extracting database to a temporary location...

This redundancy is potentially confusing and may cause people to think
something is wrong. Historically, this message came from a time when we
only extracted one database, but repo-add was changed to always create
the files database in commit cb0f2bd0385f447e045e2b2aab9ffa55df3c2d8a
and whole code block with message intact was moved into a for loop and
run (and printed) twice.

Signed-off-by: Eli Schwartz <eschwartz at archlinux.org>
---
 scripts/repo-add.sh.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/repo-add.sh.in b/scripts/repo-add.sh.in
index cff52d4e..bccf2f37 100644
--- a/scripts/repo-add.sh.in
+++ b/scripts/repo-add.sh.in
@@ -543,7 +543,7 @@ prepare_repo_db() {
 				fi
 			fi
 			verify_signature "$dbfile"
-			msg "$(gettext "Extracting database to a temporary location...")"
+			msg "$(gettext "Extracting %s to a temporary location...")" "${dbfile##*/}"
 			bsdtar -xf "$dbfile" -C "$tmpdir/$repo"
 		else
 			case $cmd in
-- 
2.19.1


More information about the pacman-dev mailing list