[pacman-dev] [PATCH 2/2] User-visible log when validity check fails due to access

[David Phillips]

Currently, if checking the validity of packages fails due to an access
error on one or more packages, the user must sift through debug output
in order to find the culprit package(s). This patch adds a call to
_alpm_log in such a case to make the culprits more easily visible.
---
 lib/libalpm/sync.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lib/libalpm/sync.c b/lib/libalpm/sync.c
index 699fb2fd..1b04e8d4 100644
--- a/lib/libalpm/sync.c
+++ b/lib/libalpm/sync.c
@@ -1190,6 +1190,11 @@ static int check_validity(alpm_handle_t *handle,
 			case ALPM_ERR_PKG_INVALID_CHECKSUM:
 				prompt_to_delete(handle, v->path, v->error);
 				break;
+			case ALPM_ERR_PKG_NOT_FOUND:
+			case ALPM_ERR_BADPERMS:
+			case ALPM_ERR_PKG_OPEN:
+				_alpm_log(handle, ALPM_LOG_ERROR, _("failed to read file %s: %s\n"), v->path, alpm_strerror(v->error));
+				break;
 			default:
 				/* ignore */
 				break;
-- 
2.18.0