[pacman-dev] [PATCH] pacman/callback: fix buffer over-read

László Várady laszlo.varady93 at gmail.com
Mon Aug 5 13:12:15 UTC 2019


Thanks for the review!

> Ok, but maybe we should remove the now redundant null termination after
> the if block.
I believe the '\0' character after the if block is not completely
redundant, it
terminates the stripped package name which can be shorter than the original
string. `len` is modified according to this operation.

I'm moving the mentioned line inside the if statement.

László Várady

More information about the pacman-dev mailing list