[pacman-dev] [PATCH] makepkg: Delete logpipe when cleaning up

[Eli Schwartz]

On 8/26/19 6:20 PM, Austin Lund wrote:
> I can trigger it with just basic makepkg followed by Ctrl-C to trigger
> SIGINT or something like makepkg & sleep 5; kill -USR1 $! .

Please do add that to the commit message, though! Since it was plainly
unclear to people what you meant by "a number of exit paths", I consider
this important information to record in the commit message history.

>> Why switch from
>> if [[ -p $logpipe ]]; then rm "$logpipe"; fi
>> to
>> [[ -p $logpipe ]] && rm "$logpipe"
>>
>> Seems a bit silly to add new cases of `return 1` to our cleanup function.
> 
> Indeed.  I forgot the special return behaviour of 'if' constructs when
> the conditions are false.  I will submit a revised patch.

Thanks.

-- 
Eli Schwartz
Bug Wrangler and Trusted User

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 1601 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/pacman-dev/attachments/20190826/80cd7b41/attachment-0001.sig>