[pacman-dev] [PATCH 2/2] wip: pacman: rework the UI of -F

[Morgan Adamiec]

On Thu, 7 Feb 2019 at 01:31, Allan McRae <allan at archlinux.org> wrote:
>
> On 3/2/19 4:42 am, morganamilo wrote:
> > Reworks the UI of -F according to FS#47949
> >
> > In short -F replaces both -Fs and -Fo.
> > --regex/-x has been replaced with --search/-s.
> >
> > Signed-off-by: morganamilo <morganamilo at gmail.com>
> > ---
> >
> > This patch is WIP. Functional changes made,
> > documentation still needs to be changed.
> >
> > Additionally I think https://bugs.archlinux.org/task/47949#comment143477
> > Is a good idea and I will probably be included in v2
> >
>
> I'm OK with the changes (without having done a review of your code...).
>  However, I think we need to work on the output.
>
>
> Old:
> $ pacman -Fo opt/
> opt/ is owned by core/filesystem 2018.12-2
> opt/ is owned by extra/bullet 2.88-1
> opt/ is owned by extra/postgresql-old-upgrade 10.6-1
> opt/ is owned by community/9base 6-6
> opt/ is owned by community/aspnet-runtime 2.2.1+102-1
> ...
>
> New:
> $ ./src/pacman/pacman -F opt/
> core/filesystem 2018.12-2 (base) [installed]
>     opt/
> extra/bullet 2.88-1
>     opt/
> extra/postgresql-old-upgrade 10.6-1
>     opt/
> ...
>
>
> So the new output follows the old -Fs, which was good when the filepath
> was different for each match.  But it not great for some situations
> now...  That output remains good for the new -Fs (rainbow issues being
> ignored!), but a rethink is needed for the new -F operations.
>
> Allan

What if we keep-Fo but have it just change the output format? -F and
-Fo would both work on files and paths.