[pacman-dev] [PATCH] Fixes bug FS 59201

Allan McRae allan at archlinux.org
Sun Feb 10 12:33:11 UTC 2019


On 10/2/19 10:11 pm, Sever Oraz wrote:
> Signed-off-by: Sever Oraz <severoraz at gmail.com>

For context, bug 59201 points out that the K/s used in the download
speed is unclear.   We have no idea what K means - is it KB or KiB?
Looking at actual output:

 archlinux-keyring-2...   685.1 KiB   694K/s 00:01
[######################] 100%
 libsystemd-240.93-1...   388.0 KiB   693K/s 00:01
[######################] 100%
 cryptsetup-2.1.0-1-...   392.7 KiB   865K/s 00:00
[######################] 100%

Clearly it is *iB and not *B, just like the unit 6 characters to the
left.   I'm not keen on removing two columns (plus a space in this
patch) from the progress bar to add this in.

Also, this patch is clearly not tested.  I now get this:

:: Retrieving packages...
 systemd-240.93-1-x86_64    0.0   B  0.00   B/s 00:00
[----------------------]   systemd-240.93-1-x86_64   80.0 KiB   117
KiB/s 00:33 [----------------------]   systemd-240.93-1-x86_64  160.0
KiB   196 KiB/s 00:19 [----------------------]   systemd-240.93-1-x86_64
 256.0 KiB   283 KiB/s 00:13 [#---------------------]
systemd-240.93-1-x86_64  352.0 KiB   336 KiB/s 00:10
[#---------------------]   systemd-240.93-1-x86_64  448.0 KiB   384
KiB/s 00:09 [##--------------------]   systemd-240.93-1-x86_64  543.9
KiB   416 KiB/s 00:08 [##--------------------]   systemd-240.93-1-x86_64
 672.0 KiB   484 KiB/s 00:06 [###-------------------]
systemd-240.93-1-x86_64  783.9 KiB   504 KiB/s 00:06
[####------------------]   systemd-240.93-1-x86_64  928.0 KiB   560
KiB/s 00:05 [#####-----------------]   systemd-240.93-1-x86_64 1071.9
KiB   592 KiB/s 00:04 [#####-----------------]   systemd-240.93-1-x86_64
1232.0 KiB   645 KiB/s 00:04 [######----------------]
systemd-240.93-1-x86_64 1391.9 KiB   696 KiB/s 00:03
[#######---------------]   systemd-240.93-1-x86_64 1568.0 KiB   740
KiB/s 00:03 [########--------------]


Allan


More information about the pacman-dev mailing list