[pacman-dev] [PATCH] makepkg: simplify run_pacman logic

[Allan McRae]

On 21/2/19 11:55 am, Eli Schwartz wrote:
> We don't need to check the options twice, since it is the same check
> both times. Instead, merge the conditionals.
> 
> As far as I can tell, the only reason the checks for:
> 
> - PACMAN_OPTS and
> - whether to use sudo
> 
> were ever separated is due to the historic existence of --asroot, since
> the second check included a check for (( ! ASROOT )) until it was
> cleaned up in commit 61ba5c961e4a3536c4bbf41edb348987a9993fdb.
> 

OK - I'm not going to look at the history of that function to see who to
blame...   :D

A