[pacman-dev] [PATCH v2 1/2] Move skipping of duplicate sync/remove targets into libalpm

[Allan McRae]

On 15/12/18 6:44 am, Michael Straube wrote:
> sync:
> As pointed out by Andrew Gregory there could be an error when adding
> duplicates if they are two separate packages with the same name. Add a
> check in alpm_add_pkg() to test whether the duplicate is actually the
> same package, and if so, log a debug message and return success to skip
> the package. If the duplicate is a different package return
> ALPM_ERR_TRANS_DUP_TARGET and treat that error just like any other error
> in pacman.
> 
> remove:
> Change alpm_remove_pkg() to just log a debug message and return success
> to skip duplicates. Remove the handling of ALPM_ERR_TRANS_DUP_TARGET in
> pacman.
> 
> Also fixes FS#49377.
> 
> Suggested-by: Andrew Gregory <andrew.gregory.8 at gmail.com>
> Signed-off-by: Michael Straube <michael.straube at posteo.de>
> ---
> v1 -> v2
> debug messages not translated
> moved assigments into conditionals
> 

Great.   Committed.

Thanks,
A