[pacman-dev] [PATCH] repo-add: don't break if delta package sources contain epoch

Eli Schwartz eschwartz at archlinux.org
Fri Jan 4 02:22:56 UTC 2019


On 1/3/19 8:20 PM, Allan McRae wrote:
> On 28/12/18 9:15 am, Eli Schwartz wrote:
>> Our sed parser for xdelta3 headers will greedily match on ":" which
>> coincidentally is also the character we use to define a version with an
>> epoch.
>>
>> While we are at it, simply use sed for the whole pipeline, rather than
>> using both grep and sed.
>>
>> Fixes FS#61195
>>
>> Signed-off-by: Eli Schwartz <eschwartz at archlinux.org>
> 
> OK.
> 
> As an aside, the fact we are rewriting package version parsing code in
> bash highlights again that repo-add really should be converted to a
> libalpm program.

Ha, no arguments there. :p

-- 
Eli Schwartz
Bug Wrangler and Trusted User

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/pacman-dev/attachments/20190103/296a1001/attachment.asc>


More information about the pacman-dev mailing list