[pacman-dev] [PATCH v3] makepkg: fix broken check for the fakeroot binary

Eli Schwartz eschwartz at archlinux.org
Fri Jan 4 05:29:15 UTC 2019

On 1/4/19 12:26 AM, Eli Schwartz wrote:
> In commit d8ee8d0c99c3820951e2e49dbdb71a5390bd1dc4 we made use of
> fakeroot absolutely mandatory, and disabled a lot of the code which
> checked to see if this now-defunct BUILDENV option was set, before
> setting up the environment to use fakeroot. Unfortunately, we missed one
> spot.
> The check_software routine still checked to see if fakeroot was
> enabled, but due to the option being removed, thought that it was in
> fact disabled, and as a result this check would never run.
> Fix by checking to see if we are trying to build either a package or a
> source package, and if so, checking for fakeroot. These are the only two
> situations where fakeroot is needed.
> Signed-off-by: Eli Schwartz <eschwartz at archlinux.org>
> ---
> v3: as originally reviewed, set BUILDPKG=0 when not actually building
> package artifacts.
I am apparently super tired tonight...

Eli Schwartz
Bug Wrangler and Trusted User

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/pacman-dev/attachments/20190104/a7af4fcb/attachment.asc>

More information about the pacman-dev mailing list