[pacman-dev] [PATCH] libmakepkg/lint_pkgbuild: check for invalid variables even if they're empty

Allan McRae allan at archlinux.org
Thu Jan 10 05:23:17 UTC 2019

On 13/6/18 11:17 am, Eli Schwartz wrote:
> Checking the length of the variable to be non-zero before considering it
> an error is inconsistent; license=() and depends='' and `declare arch`
> should be considered just as wrong.
> In fact the current check detects depends='' as non-zero and returns an
> error, but happily considers the others to be perfectly okay.
> A more reliable check is to simply see if the name has been declared
> (whether it is set or not), and then enforce that it's been declared to
> the right type.
> As an added benefit, avoiding the creation of proxy-evaled variables to
> count the number of indexes results in simpler code.
> Signed-off-by: Eli Schwartz <eschwartz at archlinux.org>

Looks good.   I'm 99% sure this was only supposed to be delayed being
committed until pacman-5.1.1 was done...


More information about the pacman-dev mailing list