[pacman-dev] [PATCH] libmakepkg: add routine for linting $SOURCE_DATE_EPOCH

Eli Schwartz eschwartz at archlinux.org
Thu Jan 10 05:58:41 UTC 2019


This can only ever be an int, and the specification states that a
malformed timestamp should be considered a fatal error.

https://reproducible-builds.org/specs/source-date-epoch/
Signed-off-by: Eli Schwartz <eschwartz at archlinux.org>
---
 scripts/Makefile.am                           |  1 +
 .../lint_config/source_date_epoch.sh.in       | 37 +++++++++++++++++++
 2 files changed, 38 insertions(+)
 create mode 100755 scripts/libmakepkg/lint_config/source_date_epoch.sh.in

diff --git a/scripts/Makefile.am b/scripts/Makefile.am
index 54a8d215..255aee2b 100644
--- a/scripts/Makefile.am
+++ b/scripts/Makefile.am
@@ -71,6 +71,7 @@ LIBMAKEPKG_IN = \
 	libmakepkg/integrity/verify_signature.sh \
 	libmakepkg/lint_config.sh \
 	libmakepkg/lint_config/paths.sh \
+	libmakepkg/lint_config/source_date_epoch.sh \
 	libmakepkg/lint_config/variable.sh \
 	libmakepkg/lint_package.sh \
 	libmakepkg/lint_package/build_references.sh \
diff --git a/scripts/libmakepkg/lint_config/source_date_epoch.sh.in b/scripts/libmakepkg/lint_config/source_date_epoch.sh.in
new file mode 100755
index 00000000..38fbfd77
--- /dev/null
+++ b/scripts/libmakepkg/lint_config/source_date_epoch.sh.in
@@ -0,0 +1,37 @@
+#!/bin/bash
+#
+#   source_date_epoch.sh - Check that reproducible builds timestamp is valid
+#
+#   Copyright (c) 2018 Pacman Development Team <pacman-dev at archlinux.org>
+#
+#   This program is free software; you can redistribute it and/or modify
+#   it under the terms of the GNU General Public License as published by
+#   the Free Software Foundation; either version 2 of the License, or
+#   (at your option) any later version.
+#
+#   This program is distributed in the hope that it will be useful,
+#   but WITHOUT ANY WARRANTY; without even the implied warranty of
+#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#   GNU General Public License for more details.
+#
+#   You should have received a copy of the GNU General Public License
+#   along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+
+[[ -n $LIBMAKEPKG_LINT_CONFIG_SOURCE_DATE_EPOCH_SH ]] && return
+LIBMAKEPKG_LINT_CONFIG_SOURCE_DATE_EPOCH_SH=1
+
+LIBRARY=${LIBRARY:-'@libmakepkgdir@'}
+
+source "$LIBRARY/util/message.sh"
+
+lint_config_functions+=('lint_source_date_epoch')
+
+
+lint_source_date_epoch() {
+	if [[ $SOURCE_DATE_EPOCH = *[^[:digit:]]* ]]; then
+		error "$(gettext "%s contains invalid characters: %s")" \
+			"\$SOURCE_DATE_EPOCH" "${SOURCE_DATE_EPOCH//[[:digit:]]}"
+		return 1
+	fi
+}
-- 
2.20.1


More information about the pacman-dev mailing list