[pacman-dev] [PATCH] libmakepkg: make gettext replacements more templated

Eli Schwartz eschwartz at archlinux.org
Mon Jan 21 04:31:21 UTC 2019


Making the undescore be translated is probably not something we need
translators to think about.

Additionally, a number of places which use the same text differ only by
the variable being referenced, so simplifying the string means we can
drop a redundant translation.

Bonus: we save a few bytes here and there. \o/
Signed-off-by: Eli Schwartz <eschwartz at archlinux.org>
---
 scripts/libmakepkg/lint_pkgbuild/variable.sh.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/libmakepkg/lint_pkgbuild/variable.sh.in b/scripts/libmakepkg/lint_pkgbuild/variable.sh.in
index 1ee3c834..d19c95bc 100644
--- a/scripts/libmakepkg/lint_pkgbuild/variable.sh.in
+++ b/scripts/libmakepkg/lint_pkgbuild/variable.sh.in
@@ -86,7 +86,7 @@ lint_variable() {
 
 			for i in ${arch_array[@]}; do
 				if extract_function_variable "package_$pkg" "${i}_${a}" 0 out; then
-					error "$(gettext "%s_%s should be an array")" "$i" "$a"
+					error "$(gettext "%s should be an array")" "${i}_${a}"
 					ret=1
 				fi
 			done
-- 
2.20.1


More information about the pacman-dev mailing list