[pacman-dev] [PATCH 2/5] signing: add ability to import keys using a WKD

Jonas Witschel diabonas at gmx.de
Wed Jul 17 23:50:05 UTC 2019

On 2019-07-17 22:06, Jonas Witschel wrote:
> +		if((gpg_err_code(gpg_err) == GPG_ERR_NO_ERROR) && (strcmp(key->subkeys->fpr, fpr) == 0)) {

Sorry, I just realised this will never be true because "fpr" comes from
"parse_subpacket" and is always the 8 byte key ID, while
"key->subkeys->fpr" is the full 20 byte fingerprint. We need to compare
with "fpr" with "key->subkeys->keyid" instead, see attached for the
corrected patch that also adds some more debugging output in case of a
key mismatch.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/pacman-dev/attachments/20190718/e77343f3/attachment.sig>

More information about the pacman-dev mailing list