[pacman-dev] [PATCH v2] Reformatting log timestamp to include time-zone

Allan McRae allan at archlinux.org
Tue Mar 19 01:54:19 UTC 2019

On 8/3/19 11:14 am, Florian Wehner wrote:
>> The tm_gmtoff field is derived from BSD and is a GNU library
>> extension;
>> So we can't use that.
> Why reinventing the wheel? Using `strftime` would do the work for us,
> right?
> --Florian

Thanks.   For future reference, comments like the above should go below
the "---" at the bottom of the commit message.


> The time logged is currently given as localtime without any timezone
> information. This is confusing in various scenarios.
> Examples:
> * If one is travelling across time-zones and the timestamps in the log
> appear out of order.
> * Comparing dates with `datediff` gives an offset by the time-zone
> This patch would reformat the time-stamp to a full ISO-8601 version.
> It includes the 'T' separating date and time including seconds.
> Old: [2019-03-04 16:15]
> New: [2019-03-04T16:15:45-05:00]
> Signed-off-by: Florian Wehner <florian at whnr.de>
> ---

More information about the pacman-dev mailing list