[pacman-dev] [PATCH 3/3] doc: elaborate on what a build() function is meant for

[Eli Schwartz]

On 3/19/19 12:14 AM, Allan McRae wrote:
> On 13/3/19 3:01 am, Eli Schwartz wrote:
>> It is often not obvious to people, that build() can be run multiple
>> times when continuing a build with --noextract.
>>
>> Signed-off-by: Eli Schwartz <eschwartz at archlinux.org>
>> ---
>>  doc/PKGBUILD.5.asciidoc | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/doc/PKGBUILD.5.asciidoc b/doc/PKGBUILD.5.asciidoc
>> index 83a61458..6336a5cd 100644
>> --- a/doc/PKGBUILD.5.asciidoc
>> +++ b/doc/PKGBUILD.5.asciidoc
>> @@ -359,7 +359,11 @@ function.
>>  
>>  *build() Function*::
>>  	The optional `build()` function is use to compile and/or adjust the source
>> -	files in preparation to be installed by the `package()` function.
>> +	files in preparation to be installed by the `package()` function. All
>> +	commands specific to the package creation (but not source code
>> +	preparation), before the final installation of files into the packaging
>> +	root, should be performed here. The `build()` function is permitted to run
>> +	multiple times if `makepkg --noextract` is used.
> 
> The last sentence is confusing.  I know when the build() function runs,
> but still took too long to parse what you meant.

Would it help to say:

s/run/be executed/


-- 
Eli Schwartz
Bug Wrangler and Trusted User

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 1601 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/pacman-dev/attachments/20190319/47b64b6f/attachment-0001.sig>