[pacman-dev] [PATCH 2/2] libalpm: set errno in signing dummy functions

morganamilo morganamilo at gmail.com
Tue Oct 15 08:58:49 UTC 2019


This allows pacman to print the correct error message when checking keys
and libalpm has been compiled without gpgme support.

diff --git a/lib/libalpm/signing.c b/lib/libalpm/signing.c
index 4cb31e7c..8522e049 100644
--- a/lib/libalpm/signing.c
+++ b/lib/libalpm/signing.c
@@ -790,12 +790,14 @@ error:
 #else /* HAVE_LIBGPGME */
 int _alpm_key_in_keychain(alpm_handle_t UNUSED *handle, const char UNUSED *fpr)
 {
+	handle->pm_errno = ALPM_ERR_MISSING_CAPABILITY_SIGNATURES;
 	return -1;
 }
 
 int _alpm_key_import(alpm_handle_t UNUSED *handle, const char UNUSED *uid,
 		const char UNUSED *fpr)
 {
+	handle->pm_errno = ALPM_ERR_MISSING_CAPABILITY_SIGNATURES;
 	return -1;
 }
 
@@ -803,6 +805,7 @@ int _alpm_gpgme_checksig(alpm_handle_t UNUSED *handle, const char UNUSED *path,
 		const char UNUSED *base64_sig, alpm_siglist_t UNUSED *siglist)
 {
 	siglist->count = 0;
+	handle->pm_errno = ALPM_ERR_MISSING_CAPABILITY_SIGNATURES;
 	return -1;
 }
 #endif /* HAVE_LIBGPGME */
-- 
2.23.0


More information about the pacman-dev mailing list