[pacman-dev] [PATCH 1/2] makepkg: use null-delimited file lists when tracking inodes

Ronan Pigott rpigott314 at gmail.com
Sun Oct 27 07:03:44 UTC 2019


On Sun Oct 27, 2019 at 2:42 AM Eli Schwartz wrote:
> You mention:
> 
> > To make supporting whitespace in filenames easier, I changed INODECMD
> > to output only the inode and instead rely on find's -print0 to
> > reliably
> > parse complete filenames. This fixes some errors for files that begin
> > or end in whitespace. It was noted in discussion that -print0 is not
> 
> But your replacement has the same issue. Whitespace is trimmed not by
> the -d ' ' in use (which reads in the first line of input until it hits
> the first space character, deletes the space character, and then
> declares the line to be over and assigns the line to $inode), but by the
> IFS in the second read (since IFS is used to split the line, even if
> there is only one variable to assign it will still strip leading and
> trailing $IFS).

Ah that does seem to be the case. Good catch. I'll remove this change
and use the existing INODECMD format.


More information about the pacman-dev mailing list