[pacman-dev] [PATCH 1/1] makepkg: send output from clean_up to stderr

Eli Schwartz eschwartz at archlinux.org
Mon Oct 28 15:31:00 UTC 2019


On 10/28/19 11:22 AM, Christian Hesse wrote:
> From: Christian Hesse <mail at eworm.de>
> 
> This is required when redirecting checksums to PKGBUILD:
> 
> makepkg --clean --geninteg >> PKGBUILD

Why would anyone ever use --clean and --geninteg in the same run? We
should make sure they cannot do that, rather than changing where the
output of makepkg --clean *without* --geninteg is sent.

> ---
>  scripts/makepkg.sh.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
> index 183e1a3e..3017f31b 100644
> --- a/scripts/makepkg.sh.in
> +++ b/scripts/makepkg.sh.in
> @@ -1101,7 +1101,7 @@ while [[ $1 ]]; do
>  done
>  
>  # setup signal traps
> -trap 'clean_up' 0
> +trap 'clean_up >&2' 0
>  for signal in TERM HUP QUIT; do
>  	trap "trap_exit $signal \"$(gettext "%s signal caught. Exiting...")\" \"$signal\"" "$signal"
>  done
> 


-- 
Eli Schwartz
Bug Wrangler and Trusted User

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 1601 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/pacman-dev/attachments/20191028/f60d2663/attachment.sig>


More information about the pacman-dev mailing list