[pacman-dev] [PATCH] Use noextract with pacman-conf NoExtract

Eli Schwartz eschwartz at archlinux.org
Wed Apr 1 15:29:57 UTC 2020


From: Earnestly <zibeon at googlemail.com>

Current code accidently uses noupgrade for the NoExtract directive.

https://medium.com/@Code_Analysis/the-last-line-effect-7b1cb7f0d2a1

Signed-off-by: Eli Schwartz <eschwartz at archlinux.org>
---

Previously fixed in
https://github.com/andrewgregory/pacutils/commit/64c7d0aca1a3aa3be5b7789f10ee1e5c9e0d7471
but the unfixed version got merged here. :/

 src/pacman/pacman-conf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/pacman/pacman-conf.c b/src/pacman/pacman-conf.c
index 939cbdbd..f67ec21f 100644
--- a/src/pacman/pacman-conf.c
+++ b/src/pacman/pacman-conf.c
@@ -348,7 +348,7 @@ static int list_directives(void)
 		} else if(strcasecmp(i->data, "NoUpgrade") == 0) {
 			show_list_str("NoUpgrade", config->noupgrade);
 		} else if(strcasecmp(i->data, "NoExtract") == 0) {
-			show_list_str("NoExtract", config->noupgrade);
+			show_list_str("NoExtract", config->noextract);
 
 
 		} else if(strcasecmp(i->data, "Architecture") == 0) {
-- 
2.26.0


More information about the pacman-dev mailing list