[pacman-dev] [PATCH 1/3] meson: replace objects with link_whole

[Eli Schwartz]

On 12/23/20 5:42 PM, Emil Velikov wrote:
> Instead extracting/listing objects from existing static libraries,
> simply add those to the link list. Note that link_whole is needed
> otherwise, unused code will be pruned.
This is intentional! link_whole is broken, just like the comment says.

It is fixed in newer versions of meson than the current minimum. The fix 
is that link_whole does precisely what extract_all_objects() does. In 
other words, link_whole is syntactic sugar for extract_all_objects().

I have intended to switch to link_whole, but *only* once we bump the 
minimum version of meson to something that guarantees the result is 
functional.

I didn't want to bump the minimum version of meson just for this.

-- 
Eli Schwartz
Bug Wrangler and Trusted User

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/pacman-dev/attachments/20201223/52dc540e/attachment.sig>