[pacman-dev] [PATCH] makepkg: drop duplicate reporting of missing dependencies

[Allan McRae]

On 6/2/20 10:48 pm, Dave Reisner wrote:
> When pacman fails to satisfy deps, we might see output like the
> following:
> 
> ==> Making package: spiderfoot 3.0-1 (Thu 06 Feb 2020 12:45:10 PM CET)
> ==> Checking runtime dependencies...
> ==> Installing missing dependencies...
> error: target not found: python-pygexf
> ==> ERROR: 'pacman' failed to install missing dependencies.
> ==> Missing dependencies:
>   -> python-dnspython
>   -> python-exifread
>   -> python-cherrypy
>   -> python-beautifulsoup4
>   -> python-netaddr
>   -> python-pysocks
>   -> python-ipwhois
>   -> python-ipaddress
>   -> python-phonenumbers
>   -> python-pypdf2
>   -> python-stem
>   -> python-whois
>   -> python-future
>   -> python-pyopenssl
>   -> python-docx
>   -> python-pptx
>   -> python-networkx
>   -> python-cryptography
>   -> python-secure
>   -> python-pygexf
>   -> python-adblockparser
> ==> Checking buildtime dependencies...
> ==> ERROR: Could not resolve all dependencies.
> 
> This is misleading -- the only truly missing package is python-pygexf,
> but we fail to remove sync-able deps from our deplist and report
> everything as if it were missing. Simply drop this extra reporting
> because pacman already tells us exactly what couldn't be resolved.
> ---
> I thought about trying to make this accurate and diff the lists --
> something like:
> 
>   mapfile -t deplist < <(printf '%s\n' "${deplist}" | grep -vxFf <(run_pacman -Ssq))
> 
> but I'm not convinced this is really the right thing to do...

I'm OK with the error reported as is after this patch.  No need for more
complications.

A