[pacman-dev] [PATCH] srcinfo.sh: remove trailing newline

[Eli Schwartz]

On 6/3/20 8:04 PM, Eli Schwartz wrote:
> On 6/3/20 7:26 PM, Denton Liu wrote:
>> When the .SRCINFO file is generated via `makepkg --printsrcinfo`, each
>> section is concluded with an empty line. This means that at the end of
>> the file, an empty line remains. When running `git diff --check`, Git
>> will complain about this as a whitespace error, saying "new blank line
>> at EOF."
> 
> git diff --check isn't necessarily our problem, though...
> 
> But it will only be reported once, the very first time you ever commit
> this .SRCINFO

Also FWIW, I use git diff --check in my pre-commit githook for AUR
packages, but I also generate the .SRCINFO in that very hook, AFTER I
check for whitespace issues. Hence I don't see whitespace issues for the
.SRCINFO file, even for the very first commit. So I'm really not
motivated to change this.

For more details see https://github.com/eli-schwartz/aurpublish/#hooks

-- 
Eli Schwartz
Bug Wrangler and Trusted User

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 1601 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/pacman-dev/attachments/20200603/32e63f58/attachment.sig>