[pacman-dev] [PATCH] meson: use 'pedantic' compiler warning level

[Anatol Pomozov]

Hi

On Thu, Mar 5, 2020 at 4:50 PM Eli Schwartz <eschwartz at archlinux.org> wrote:
>
> On 3/5/20 7:42 PM, Anatol Pomozov wrote:
> > Signed-off-by: Anatol Pomozov <anatol.pomozov at gmail.com>
> > ---
> >  meson.build | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/meson.build b/meson.build
> > index 572526b2..fc81fa27 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -7,6 +7,7 @@ project('pacman',
> >            'prefix=/usr',
> >            'sysconfdir=/etc',
> >            'localstatedir=/var',
> > +          'warning_level=3',
>
> We can just use meson setup --warnlevel 3, the other settings there are
> about making sure the software works as expected.
>
> FWIW, meson.build already adds a bunch of -W flags automatically for
> buildtype=debug. This would be a better place to go adding even more.

I see, so the compiler warnings (including the GNU escape symbols
detection) are enabled at Debug mode only.

What is the reason avoid compile warnings with the Release mode?
'meson setup' uses Release mode by default (unless no cmdline options
override it) and I bet most of the contributors are just going to use
this default. Having warnings enabled with the default setup
eliminates potential WTF moments.