[pacman-dev] [PATCH v2] Extend download callback interface with start/complete events

Allan McRae allan at archlinux.org
Wed May 6 04:15:28 UTC 2020


On 6/5/20 12:50 pm, Anatol Pomozov wrote:
> With the previous download interface the callback uses the first progress
> event as 'download has started' signal. Unfortunately it does not work with
> up-to-date files that never receive 'download progress' events.
> Up-to-date database messages are currently handled in sync_syncdbs()
> after the sequential download is completed and a result from ALPM is
> received. But this is not going to work with multiplexed download
> interface that returns the result only after all files are completed.
> 
> Another problem with 'first progress event is the beginning of the
> download' is that such events time are unpredictable. Thus the UI progress
> bar order might differ from what has been passed by client to
> alpm_dbs_update() function. We actually want to keep the dbs progress bars
> in a strict order.
> 
> To help to solve the given problems extend the download callback to
> allow 2 more events - download started and completed. 'Download started'
> events appear in the same order as in the list given by a client.
> 
> Signed-off-by: Anatol Pomozov <anatol.pomozov at gmail.com>
> ---

OK.


More information about the pacman-dev mailing list