[pacman-dev] [PATCH] Remove alpm_db_update() function

Anatol Pomozov anatol.pomozov at gmail.com
Thu May 7 01:46:03 UTC 2020


On Tue, Apr 28, 2020 at 6:57 PM Allan McRae <allan at archlinux.org> wrote:
> On 19/4/20 12:22 pm, Anatol Pomozov wrote:
> > This function got replaced by its multiplexed couterpart alpm_dbs_update().
> > If one needs to reproduce alpm_db_update() functionality then create a
> > single item list and pass it to alpm_dbs_update().
> >
> This patch is good. However, I would like alpm_dbs_update() renamed to
> alpm_db_update().
> All our database functions are in the form alpm_db_xxxx().  For users of
> the library, it makes little difference whether the API change is a
> change in function name vs change in function signature.

Sounds good, PTAL. I also updated README to mention this API change.

It is interesting to see how this alpm_db_update() refactoring went
through multiple steps: "introduce new functionality" -> "port all the
callers to the new functions" -> "remove old functions" -> "rename new
functions to match the old API". And the project was fully functional
during each of these milestones.

More information about the pacman-dev mailing list