[pacman-dev] [PATCH v2] Swap alpm_db_update() implementation to multiplexed version

[Allan McRae]

On 12/5/20 12:27 am, guillaume at manjaro.org wrote:
> Hi Allan, Hi Anatol,
> 
> I was looking to this new multiplexed implementation and I found some
> problems:
> 1) This implementation can lead to download databases from different
> servers, I think it can't be a problem if they are not synced

As I said elsewhere, this could happen in the single download code too.
 So not a new issue.  This could be fixed (but note not all repos have
the same server - only those provided by a distro), but it is beyond
this patch.

> 2) Differents download payloads are created for databases and its
> signature files, this can this time lead to download the database and
> its signature from differents server, I'm sure it's not wanted.

Signature files coming from different servers is fine.  You probably
have that all the time with source code downloaded from places with
various load balancing.  Signature files for servers in different sync
states is an issue - only for databases, packages are fine.

> 3) Because signature files have their own download payloads, if the
> signature is missing on a the first server (e.g. database signature is
> optional), all next servers will be tried and all will give the same error.

This is an issue.  And I guess the fix would fix #2 too.

It would be good to open a bug for this.

> I really wanted to suggest a patch but I didn't find a easy way
> (understand a small patch) to fix it and I would like your opinion on
> point 1) first.
> 
> Regards,
> Guillaume.
> .