[pacman-dev] [PATCH] Avoid depending on side effects in assert(...) expressions

Allan McRae allan at archlinux.org
Thu May 14 05:41:23 UTC 2020

On 14/5/20 12:54 pm, Andrew Gregory wrote:


>  The
> callback api should be fixed so that callbacks can indicate an error
> that should cancel the download.

Probably - there are a lot of points in the codebase where we pass an
error back but don't really do much with it...  Or don't pass back an error.

> I'd also say we should be passing the full list of download items to
> the callback so that it's possible to write at least a very simple
> multi-download callback without having to maintain a bunch of
> complicated state information.

I was fairly happy with the multi-download callback.  It was at a point
that it worked and was functionally correct (as far as I could tell),
but there are likely ways to make it better such as your idea.  However,
I'm not letting that stop anything good and working being committed to
the tree as improvements can happen later.  Perfect being the enemy of
good and all that.


More information about the pacman-dev mailing list