[pacman-dev] [PATCH] libalpm/signing.c: Fix calculation of packet size in parse_subpacket

Allan McRae allan at archlinux.org
Sun May 31 22:42:30 UTC 2020


On 1/6/20 5:51 am, Andrew Gregory wrote:
> On 05/20/20 at 02:22pm, Allan McRae wrote:
>> Given RFC 4880 provides the code to do this calculation, I am not sure
>> how I managed to stuff that up!  This bug was only exposed when a
>> signature made with "include-key-block" was added to the Arch repos,
>> which provided a subpacket with the required size to hit this issue.
> 
> LGTM. Though, it might be worth it to use + instead of | just so we
> match 4880 and extract_keyid exactly.
> 

Done.


More information about the pacman-dev mailing list