[pacman-dev] [PATCH 3/5] libalpm: clarify alpm_download_event_completed_t status

morganamilo morganamilo at archlinux.org
Tue Nov 24 12:39:06 UTC 2020


The comment makes it seem that the result itself is an error code. But
all it does is simply return -1 to indicate an error occured;

diff --git a/lib/libalpm/alpm.h b/lib/libalpm/alpm.h
index 614a530c..6a7323e0 100644
--- a/lib/libalpm/alpm.h
+++ b/lib/libalpm/alpm.h
@@ -728,9 +728,9 @@ typedef struct {
 	/* total bytes in file */
 	off_t total;
 	/* download result code:
-	 *   0 - download completed successfully
-	 *   1 - the file is up-to-date
-	 *   negative - error code
+	 *    0 - download completed successfully
+	 *    1 - the file is up-to-date
+	 *   -1 - error
 	 */
 	int result;
 } alpm_download_event_completed_t;
-- 
2.29.2


More information about the pacman-dev mailing list