[pacman-dev] [PATCH 1/2] makepkg: fix signing of source packages

Eli Schwartz eschwartz at archlinux.org
Mon Oct 12 03:18:55 UTC 2020


On 10/11/20 10:22 PM, Eli Schwartz wrote:
> In commit c6b04c04653ba9933fe978829148312e412a9ea7 the signing stage was
> moved out of fakeroot, and thus into the main control flow instead of
> create_{,src}package

Random factoid:

10:47 PM <amcrae> eschwartz: had I seen those patches before?
10:48 PM <eschwartz> no, I wrote them tonight
10:49 PM <amcrae> ok - it seemed familiar
10:49 PM <eschwartz> you previously merged:
10:49 PM <eschwartz> makepkg: when signing packages, report package
filename on failure
10:49 PM <eschwartz> libmakepkg/integrity: fix regression that broke
--install
10:49 PM <eschwartz> makepkg: avoid false "Signing package(s)" msg when
signing is disabled
10:50 PM <eschwartz> good grief
10:50 PM <amcrae> great patch :P
10:50 PM <eschwartz> that commit is the gift that keeps on giving


I must say, this patch really was fun. :D How on earth did it manage to
have so many edge cases....

Bets on us discovering a 5th problem?

-- 
Eli Schwartz
Bug Wrangler and Trusted User

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 1601 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/pacman-dev/attachments/20201011/8a3c14e3/attachment.sig>


More information about the pacman-dev mailing list