[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.2.1-122-g4d8f58d3
Allan McRae
allan at archlinux.org
Wed Oct 21 01:43:28 UTC 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The official pacman repository".
The branch, master has been updated
via 4d8f58d3b940f778b27c59e53ea9f3fab20a07ba (commit)
via c99a3cc867ee5bf725a5d33d57120c3764aeb41e (commit)
via f76bd2c6c1b94792112d311ac53662d3d9b6821d (commit)
from 406a37206f9afbc3731ac22eda5b45b5a15eddc5 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 4d8f58d3b940f778b27c59e53ea9f3fab20a07ba
Author: Michael Straube <michael.straubej at gmail.com>
Date: Thu Oct 15 12:56:26 2020 +0200
makepkg: emptydirs: fix typo
Fix typo in a comment in tidy_emptydirs().
Signed-off-by: Michael Straube <michael.straubej at gmail.com>
Signed-off-by: Allan McRae <allan at archlinux.org>
commit c99a3cc867ee5bf725a5d33d57120c3764aeb41e
Author: Eli Schwartz <eschwartz at archlinux.org>
Date: Sun Oct 11 22:22:05 2020 -0400
makepkg: properly localize some internal function variables
We leaked fullver and pkgarch all over the place, and only conditionally
unset the other variables. Marking them local is a more proactive
solution.
Signed-off-by: Eli Schwartz <eschwartz at archlinux.org>
Signed-off-by: Allan McRae <allan at archlinux.org>
commit f76bd2c6c1b94792112d311ac53662d3d9b6821d
Author: Eli Schwartz <eschwartz at archlinux.org>
Date: Sun Oct 11 22:22:04 2020 -0400
makepkg: fix signing of source packages
In commit c6b04c04653ba9933fe978829148312e412a9ea7 the signing stage was
moved out of fakeroot, and thus into the main control flow instead of
create_{,src}package
While the function for signing binary packages has logic to build
and gpg-sign multiple filenames, the source package never got this
special treatment. This would be fine, except it uses the standard
variables to set define the filename... like ${fullver}, which is
usually set beforehand, but in this case is not. We don't define fullver
globally as it's an internal implementation detail, except by sheer
coincidence if PKGVERFUNC is false due to improperly guarded code.
Result: source packages didn't end up signed. Instead, we raised a logic
error:
==> WARNING: Failed to sign package file somepackage-.src.tar.gz.
==> ERROR: An unknown error has occurred. Exiting...
Instead, let's just build the version inline, since we only use it once.
Reported-by: GaKu999 <g4ku999 at gmail.com>
Signed-off-by: Eli Schwartz <eschwartz at archlinux.org>
Signed-off-by: Allan McRae <allan at archlinux.org>
-----------------------------------------------------------------------
Summary of changes:
scripts/libmakepkg/tidy/emptydirs.sh.in | 2 +-
scripts/makepkg.sh.in | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
hooks/post-receive
--
The official pacman repository
More information about the pacman-dev
mailing list