[pacman-dev] [PATCH] libmakepkg: lint all arrays for empty values
Morgan Adamiec
morganamilo at archlinux.org
Tue Oct 27 23:39:29 UTC 2020
Accidentally sent off list. resending:
Because there's no reason for a pkgbuild to ever do this so may as well
make it a hard error. AUR packages can't be trusted to get it right.
We already make an effort to link pkgbuilds to make sure they're right.
I don't how this is different to the other lints.
On 27/10/2020 22:48, Allan McRae wrote:
> On 28/10/20 7:44 am, morganamilo wrote:
>> ---
>>
>> I've seen this out in the wild:
>> https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=vim-coc-highlight-git&id=3063e1a6d3e72a35528
>>
>
> Why would this be an error? I think it would be a warning at best.
>
> Also, I think PKGBUILD linting done by makepkg (as in the lints
> distributed with the pacman source) should be limited to things that
> cause issues while packaging. An empty value for the license is "fine"
> as far as makepkg is concerned.
>
> Allan
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/pacman-dev/attachments/20201027/f008cff7/attachment.sig>
More information about the pacman-dev
mailing list