[pacman-dev] [PATCH] makepkg: fix the use of spaces in the localname:: component of sources

Eli Schwartz eschwartz at archlinux.org
Mon Apr 5 21:13:12 UTC 2021


Broken via refactoring in commit aa6fe1160b39cd364a6595b7c9f56acb1cea3432
but for obvious reasons only one person in the last 9 years has ever
actually tried to do this. Still, it's technically correct to allow it.

Fixes FS#70254

Signed-off-by: Eli Schwartz <eschwartz at archlinux.org>
---
 scripts/libmakepkg/util/source.sh.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/libmakepkg/util/source.sh.in b/scripts/libmakepkg/util/source.sh.in
index 029bf8ed4..cd6ccbe69 100644
--- a/scripts/libmakepkg/util/source.sh.in
+++ b/scripts/libmakepkg/util/source.sh.in
@@ -58,7 +58,7 @@ get_filename() {
 
 	# if a filename is specified, use it
 	if [[ $netfile = *::* ]]; then
-		printf "%s\n" ${netfile%%::*}
+		printf "%s\n" "${netfile%%::*}"
 		return
 	fi
 
-- 
2.31.1


More information about the pacman-dev mailing list