[pacman-dev] [PATCH 1/2] skip servers with too many errors

Allan McRae allan at archlinux.org
Wed Apr 7 12:38:02 UTC 2021


On 28/3/21 7:30 pm, Andrew Gregory wrote:
> Keep track of errors from servers so that bad ones can be skipped once
> a threshold is reached.  Key the error tracking off the hostname because
> hosts may serve multiple repos under different url's and errors are
> likely to be host-wide.
> 
> Implements: FS#29293.
> 
> Signed-off-by: Andrew Gregory <andrew.gregory.8 at gmail.com>
> ---
> 
> Changes from 1st draft:
> * error list is now tracked on the handle, i.e. servers blacklisted during
>   -y will still be ignored during -u
> * a warning message is printed when a server is ignored
> * error tracking keys off the hostname
> 
> I have not removed the individual error messages.  I agree with Emil
> that those messages provide useful information to the user about what,
> if anything, they need to do about their mirrorlist.  I think a small
> number of similar error messages is worth the utility they add.
> 
>  lib/libalpm/alpm.c   |  1 +
>  lib/libalpm/dload.c  | 89 ++++++++++++++++++++++++++++++++++++++++++--
>  lib/libalpm/handle.h |  1 +
>  3 files changed, 87 insertions(+), 4 deletions(-)
> 

Thanks - no comments on the patch from me, and everything appears to
work as expected.

Allan


More information about the pacman-dev mailing list