[pacman-dev] [PATCH] makepkg: add tool details to buildinfo to aid determining flags

[Levente Polyak]

On 4/22/21 9:59 PM, Morten Linderud wrote:
>> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
>> index 92cb6398..e58edfa1 100644
>> --- a/scripts/makepkg.sh.in
>> +++ b/scripts/makepkg.sh.in
>> @@ -651,6 +651,8 @@ write_buildinfo() {
>>  	write_kv_pair "builddate" "${SOURCE_DATE_EPOCH}"
>>  	write_kv_pair "builddir"  "${BUILDDIR}"
>>  	write_kv_pair "startdir"  "${startdir}"
>> +	write_kv_pair "buildtool" "${BUILDTOOL:-makepkg}"
>> +	write_kv_pair "buildtoolver" "${BUILDTOOLVER:-$makepkg_version}"
>>  	write_kv_pair "buildenv" "${BUILDENV[@]}"
>>  	write_kv_pair "options" "${OPTIONS[@]}"
> 
> I think we should bump the .BUILDINFO version with this change?
> 

The format version has already been bumped and there was no release yet
with the increased version.

I consider such change equal to ABI soname bumps so I do not believe we
need additional bumps since pre release.

cheers,
Levente

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/pacman-dev/attachments/20210422/c06ccead/attachment.sig>