[pacman-dev] [PATCH v2] pacman-key: --refresh-keys queries WKD before keyserver

[Morten Linderud]

On Wed, Feb 24, 2021 at 10:57:47PM +1000, Allan McRae wrote:
> On 22/2/21 9:09 am, Morten Linderud wrote:
> > From: Morten Linderud <morten at linderud.pw>
> > +		# if no key was found, fall back to using the keyservers (with the key fingerprint instead)
> > +		if (( $? )) &&  ! "${GPG_PACMAN[@]}" --refresh-keys "$id"; then
> > +			error "$(gettext "The following key could not be updated from WKD or keyserver: %s")" "$id"
> 
> This error message is verbose.  "The following key..."  is not needed.
> It would be strange if we listed the key id not associated with the
> message!  And the user does not care that both WKD and keyserver failed,
> just that there is a failure.
> 
> How about:
> 
> error "$(gettext "Could not update key: %s") "$id"

Ack!

Looks good to me!

-- 
Morten Linderud
PGP: 9C02FF419FECBE16
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.archlinux.org/pipermail/pacman-dev/attachments/20210224/5101cfa3/attachment.sig>