[pacman-dev] [PATCH v2 3/3] Remove unused SYMHIDDEN macros

Emil Velikov emil.l.velikov at gmail.com
Tue Jan 5 00:48:13 UTC 2021


The macro hasn't been used since 2007 with commit
7f7da2b5fc01f46d28236384540c7ecfdac16a63. Although it was still copied
over into alpm_list.c an year or so later with commit ca1a1871 ("More
cleanup to alpm_list")

Just remove all instances of it.

Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
---
 doc/Doxyfile.in         | 1 -
 lib/libalpm/alpm_list.c | 1 -
 lib/libalpm/util.h      | 1 -
 3 files changed, 3 deletions(-)

diff --git a/doc/Doxyfile.in b/doc/Doxyfile.in
index 6744e765..3b9c7c22 100644
--- a/doc/Doxyfile.in
+++ b/doc/Doxyfile.in
@@ -287,7 +287,6 @@ SEARCH_INCLUDES        = YES
 INCLUDE_PATH           = ../..
 INCLUDE_FILE_PATTERNS  = *.h
 PREDEFINED             = HAVE_CONFIG_H= \
-                         SYMHIDDEN= \
                          SYMEXPORT= \
                          HAVE_LIBARCHIVE \
                          HAVE_LIBCURL \
diff --git a/lib/libalpm/alpm_list.c b/lib/libalpm/alpm_list.c
index 2ecc8e0b..e92573a1 100644
--- a/lib/libalpm/alpm_list.c
+++ b/lib/libalpm/alpm_list.c
@@ -30,7 +30,6 @@
 
 /* check exported library symbols with: nm -C -D <lib> */
 #define SYMEXPORT __attribute__((visibility("default")))
-#define SYMHIDDEN __attribute__((visibility("internal")))
 
 /* Allocation */
 
diff --git a/lib/libalpm/util.h b/lib/libalpm/util.h
index 03c8ed44..ca61a804 100644
--- a/lib/libalpm/util.h
+++ b/lib/libalpm/util.h
@@ -163,7 +163,6 @@ char *strsep(char **, const char *);
 
 /* check exported library symbols with: nm -C -D <lib> */
 #define SYMEXPORT __attribute__((visibility("default")))
-#define SYMHIDDEN __attribute__((visibility("internal")))
 
 #define UNUSED __attribute__((unused))
 
-- 
2.30.0


More information about the pacman-dev mailing list