[pacman-dev] [PATCH 2/2] pacman: clap transfer rate to >=0

[Morgan Adamiec]

On 16/01/2021 22:50, Allan McRae wrote:
> On 17/1/21 5:34 am, Andrew Gregory wrote:
>> On 01/16/21 at 04:32pm, morganamilo wrote:
>>> Sometimes when downloading packages the transfer rate drops in to the
>>> negative. Not only is this incorrect, but it messes with the allignment
>>> of the progress bars. So lets make sure it's always >= 0.
>>>
>>> ---
>>>
>>> This may not be the best fix as it does not address the root issue.
>>> But I have no idea what the root issue is so it's on somebody else to
>>> fix that.
>>
>> -1.  The issue is that when alpm falls over to a new mirror the
>> download counter restarts.  pacman goes from seeing X bytes downloaded
>> to 0 and thinks -X bytes were just downloaded.  I'm not sure how alpm
>> should be presenting that event to frontends, but I would say clamping
>> to 0 is just masking problems.
>>
> 
> Is this a recent regression with the parallel downloads?    This has
> been fixed in the past - see commit e83e868a77865d42a33076605f9a90a165f7c93a
> 
> A
> 

Thanks for showing me the commit. Made a proper fix.