[pacman-dev] [PATCH] libalpm: look for up to date file anywhere in cache

[Andrew Gregory]

On 06/24/21 at 08:45pm, Morgan Adamiec wrote:
> 
> 
> On 24/06/2021 14:42, Allan McRae wrote:
> > On 15/6/21 1:42 am, morganamilo wrote:
> >> Currently when a package is in a secondary cachedir and there is no sig
> >> file, the downloader redownloads the whole file into the primary
> >> cachedir.
> >>
> >> So lets check all cachedirs for an up to date file.
> >>
> >> Fixes FS#71109
> > 
> > So...   this is a feature and not a bug.  Sort of.
> > 
> > After this patch, the .sig file ends up in the first cache and the
> > package file in the second.  If the signature file is not in the package
> > database, pacman looks alongside the package to find the signature file
> > and fails.
> > 
> > Without this patch, databases without signatures work.
> > 
> 
> And they don't with this patch? This patch shouldn't touch the database
> download code.

Not unsigned databases, databases that don't include the package
signatures.

> > Either, the .sig file needs downloaded into the secondary cache
> > directory alongside the package, or the package directly copied into
> > first cache directory.
> > 
> 
> What if the cachedir is read only?

Then both files need to be put into the cache we're writing to.