[pacman-dev] [PATCH] libalpm: remove unused error value

[Allan McRae]

On 18/5/21 11:02 am, Morgan Adamiec wrote:
>    On 17 May 2021 11:00 pm, Allan McRae <allan at archlinux.org> wrote:
> 
>      On 18/5/21 7:25 am, morganamilo wrote:
>      > ---
>      >  lib/libalpm/alpm.h  | 2 --
>      >  lib/libalpm/error.c | 2 --
>      >  2 files changed, 4 deletions(-)
>      >
>      > diff --git a/lib/libalpm/alpm.h b/lib/libalpm/alpm.h
>      > index c4acc062..a5f4a6ae 100644
>      > --- a/lib/libalpm/alpm.h
>      > +++ b/lib/libalpm/alpm.h
>      > @@ -292,8 +292,6 @@ typedef enum _alpm_errno_t {
>      >  ALPM_ERR_PKG_INVALID_NAME,
>      >  /** Package has an invalid architecture */
>      >  ALPM_ERR_PKG_INVALID_ARCH,
>      > - /** Unused */
>      > - ALPM_ERR_PKG_REPO_NOT_FOUND,
>      My guess is this was (and probably should be) used for "pacman -S
>      bar/foo".  That currently gives:
>      error: database not found: bar
>      Allan
> 
>    Should it? I find the current error message totally sufficient.
> 

The error message not used is "could not find repository for target",
which is accurate.  We don't know the repository.  We could know the
repo but not have a database downloaded, which would be the "database
not found" error.