18 Mar
2011
18 Mar
'11
2:12 p.m.
On Fri, Mar 18, 2011 at 2:01 PM, Gaetan Bisson <bisson@archlinux.org> wrote:
It looks all very good to my non-expert eye, except that I wouldn't silently fall back on use_rsync=true when btrfs returns an error (line 134 of makechrootpkg): there are probably some failure cases where we want to see the error message and not have rsync overwrite everything.
The fallback is there to make sure we do fall back to rsync if the btrfs command is available but the chroots aren't on a btrfs.