[arch-general] patch integrity check to compare tree to dbs - was: Integrity Check i686 of core, extra 28-08-2009

On Sun, Aug 30, 2009 at 04:57:52PM +0200, Henning Garus wrote:

On Sun, Aug 30, 2009 at 01:18:32PM +0200, Xavier wrote:

...

On Sun, Aug 30, 2009 at 12:56 PM, Henning Garus wrote:

...

On Sun, Aug 30, 2009 at 01:56:23AM +0200, Xavier wrote:

...

Great, thanks! It indeed found all the problems I had noticed, and much more.

It would be nice if this script could be automatically run as well, once per week or so.

Can you share the script used? Then we need to figure out if it can be run in the same place than the other script.

Since my script is largely based on check_packages.py that should be fairly straightforward. In fact my script expects parse_pkgbuilds.sh in the same directory.

I have uploaded the script to codepad: http://codepad.org/tSmNwYNI

I see. Then I am not sure whether we want to keep this check separate or just include it in check_packages.py

I kept it separate, because it deals with DBs and the ABS tree, while check_packages.py deals with the ABS tree only. On the other hand, integrating it should speed things up a bit (you run parse_pkgbuilds.sh only once) and we get rid of some duplicated code. On the downside the output can be quite long with activated --vercmp, But I am not sure if that is even useful.

Somehow integrating feels like the better idea, I will look into it.

Here it is. seems a bit shorter this way. I also changed the handling of the any arch. Checking any alone does not seem very useful, so I allowed multiple abs roots to be specified.