Re: [arch-projects] [MKINITCPIO][PATCH 2/2] Add a virtio hook

On Fri, Sep 16, 2011 at 03:48:22PM +0200, Lukas Fleischer wrote:

On Fri, Sep 16, 2011 at 09:42:21AM -0400, Dan McGee wrote:

...

On Fri, Sep 16, 2011 at 9:31 AM, Seblu wrote:

...

On Fri, Sep 16, 2011 at 2:50 PM, Dave Reisner wrote:

...

On Fri, Sep 16, 2011 at 02:39:44PM +0200, Sebastien Luttringer wrote:

...

This allow initcpio to boot vm which use virtio as network/disk backend.

Signed-off-by: Sebastien Luttringer ---  install/virtio |   15 +++++++++++++++  1 files changed, 15 insertions(+), 0 deletions(-)  create mode 100644 install/virtio

diff --git a/install/virtio b/install/virtio new file mode 100644 index 0000000..12503e9 --- /dev/null +++ b/install/virtio @@ -0,0 +1,15 @@ +build() { +    MODULES="$(checked_modules 'virtio_blk')" +    MODULES+=" $(checked_modules 'virtio_pci')"

checked_modules can take multiple parameters:

 MODULES=$(checked_modules virtio_{blk,pci})

This doesn't work but something like "virtio_\(blk\|pci\)" do the job. Define "doesn't work"? Because your solution doesn't work:

$ echo checked_modules 'virtio_\(blk\|pci\)' checked_modules virtio_\(blk\|pci\) $ echo checked_modules virtio_{blk,pci} checked_modules virtio_blk virtio_pci

checked_modules() invokes all_modules() which calls grep(1) to filter modules, so using a regular expression here should work (although it isn't perfect).

Yup, and we use this elsewhere. My mistake in reading over the function. d