Re: [arch-projects] [initscripts][PATCH 0/3] Minor cleanup to rc and disabling udevadm settle

On Sun, Apr 24, 2011 at 06:53:19PM +0200, Tom Gundersen wrote:

On Sun, Apr 24, 2011 at 3:01 AM, Dave Reisner wrote:

...

This is mostly for the first patch, which allows setting UDEV_TIMEOUT=0 to prevent 'udevadm settle' from being called. Looking back historically, this seems to cause a lot of grief with a lot of hardware. Googling turns up things such as...

https://bugs.launchpad.net/ubuntu/+source/cryptsetup/+bug/387086 https://bugzilla.redhat.com/show_bug.cgi?id=585527 http://lkml.org/lkml/2011/4/12/538 https://bbs.archlinux.org/viewtopic.php?id=117481

So, we're looking at both recent and less recent. Moreover, most people won't miss this if its disabled, as it's really just acting as a barrier for coldplug events to complete processing. As long as it's optional and documented, I think this is a reasonable thing to do.

d

diffstat:  rc         |   15 +++++++++------  rc.conf    |    3 ++-  rc.sysinit |    4 ++--  3 files changed, 13 insertions(+), 9 deletions(-)

I pushed 2 and 3, and the cleanup part of 1. I'm not sold on the need for the rest of 1, but if I'm wrong I'll push it out later.

Thanks for your work!

-t

Nah I'm not sold either. I think the behavior of --timeout=0 is sufficient, since it's informative (albeit with a level of vaguery) when it might be a bad idea to be skipping this barrier. Thanks for merging the others. d