On Sun, Jan 29, 2012 at 4:22 AM, Lukas Fleischer
A couple of things that I'd like to mention/ask:
* I decided that forcefsck always has precedence over fastboot, even if forcefsck was enabled by `shutdown -F` ("/forcefsck") and "fastboot" was specified on the kernel command line. I'm not sure whether this is the right thing to do here, but this is what systemd does and it seems quite reasonable to me. Tom, let me know if there are any reasons to do this differently (e.g. skip checks if "/forcefsck" exists and "fastboot" is specified on the kernel command line).
Sounds good.
* I didn't implement the "fsck.mode" kernel parameter that Tom mentioned in FS#26154 yet. I can implement this in a follow-up patch if you want, though. Is "fsck.mode" intended to be an alternative for "forcefsck" and "fastboot" or should we drop them in favor of that new option?
This is fine for now. We can revisit the fsck.mode stuff later. Dave: maybe we should add ARCH to the distros supporting forceboot/fastboot in systemd, but that's a different topic.
* The "sysinit_prefsck" and "sysinit_postfsck" hooks won't be run if file system checks are skipped. Will that cause any problems?
This makes sense to me I think. I'd be inclined to think that any hooks that get in trouble because of this are broken. Once the bash stuff that Dave mentioned has been fixed I'm happy to pull this. Cheers, Tom