Re: [arch-projects] [netctl][BAD PATCH] PKGBUILD: Build from git instead of tarballs

On 06.02.2013 17:22, Florian Pritz wrote:

Signed-off-by: Florian Pritz --- Makefile | 2 ++ contrib/PKGBUILD | 9 +++++++-- 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile index ad356e8..aa49652 100644 --- a/Makefile +++ b/Makefile @@ -2,6 +2,8 @@ export VERSION = 0.5

.PHONY: install install-docs docs tarball pkgbuild clean

+all: docs + install: install-docs # Configuration files install -d $(DESTDIR)/etc/netctl/{examples,hooks,interfaces} diff --git a/contrib/PKGBUILD b/contrib/PKGBUILD index 14052ec..24f1002 100644 --- a/contrib/PKGBUILD +++ b/contrib/PKGBUILD @@ -7,7 +7,7 @@ pkgdesc="Profile based systemd network management" url="http://projects.archlinux.org/netctl.git/" license=("GPL") depends=("coreutils" "iproute2" "openresolv") -#makedepends=('asciidoc') # The source tarball includes pre-built documentation. +makedepends=('asciidoc') optdepends=('dialog: for the menu based wifi assistant' 'dhclient: for DHCP support (or dhcpcd)' 'dhcpcd: for DHCP support (or dhclient)' @@ -18,10 +18,15 @@ optdepends=('dialog: for the menu based wifi assistant' 'bridge-utils: for bridge connections' ) conflicts=("netcfg") -source=(ftp://ftp.archlinux.org/other/netctl/netctl-${pkgver}.tar.xz) +source=(https://projects.archlinux.org/netctl.git/snapshot/netctl-${pkgver}.tar.gz) arch=(any) md5sums=('%md5sum%')

Patch is bad. the md5sum will always be wrong because it's from the tarball that contains the processed manpages.

+build() { + cd "$srcdir/netctl-${pkgver}" + make +} + package() { cd "$srcdir/netctl-${pkgver}" make DESTDIR="$pkgdir" install