[arch-releng] [PATCH] [releng] Update extrapkgs for transition to libisoburn in archiso.
On 08/28/2011 10:55 PM, Gerardo Exequiel Pozzi wrote:
Also unused packages removed. --- scripts/releng-chroot-manager | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/releng-chroot-manager b/scripts/releng-chroot-manager index 029e293..780946e 100755 --- a/scripts/releng-chroot-manager +++ b/scripts/releng-chroot-manager @@ -25,7 +25,7 @@ _install_archiso () {
if [ $action == recreate ] then - extrapkgs="syslinux vim mc base-devel git svn cvs pwgen mkinitcpio cdrkit squashfs-tools devtools mkinitcpio-nfs-utils nbd libui-sh" + extrapkgs="vim mc base-devel git svn cvs mkinitcpio squashfs-tools libisoburn devtools libui-sh"
mkdir -p /var/releng/ || die_error "could not create /var/releng/" mount | grep -q "/var/releng/chroot-$arch"&& die_error "Mountpoints still in place in $arch chroot. Cannot remove the chroot" oops, missed cc to arch-releng.
-- Gerardo Exequiel Pozzi \cos^2\alpha + \sin^2\alpha = 1
On Sun, 28 Aug 2011 22:57:34 -0300 Gerardo Exequiel Pozzi <vmlinuz386@yahoo.com.ar> wrote:
On 08/28/2011 10:55 PM, Gerardo Exequiel Pozzi wrote:
Also unused packages removed. --- scripts/releng-chroot-manager | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/releng-chroot-manager b/scripts/releng-chroot-manager index 029e293..780946e 100755 --- a/scripts/releng-chroot-manager +++ b/scripts/releng-chroot-manager @@ -25,7 +25,7 @@ _install_archiso () {
if [ $action == recreate ] then - extrapkgs="syslinux vim mc base-devel git svn cvs pwgen mkinitcpio cdrkit squashfs-tools devtools mkinitcpio-nfs-utils nbd libui-sh" + extrapkgs="vim mc base-devel git svn cvs mkinitcpio squashfs-tools libisoburn devtools libui-sh"
mkdir -p /var/releng/ || die_error "could not create /var/releng/" mount | grep -q "/var/releng/chroot-$arch"&& die_error "Mountpoints still in place in $arch chroot. Cannot remove the chroot" oops, missed cc to arch-releng.
Imho "Update extrapkgs for transition to libisoburn in archiso" and "Remove unused packages" should be separate commits. Even more, can you explain why each removed package is no longer needed? maybe put that in the commit message as well. Dieter
On 08/29/2011 10:25 AM, Dieter Plaetinck wrote:
On Sun, 28 Aug 2011 22:57:34 -0300 Gerardo Exequiel Pozzi<vmlinuz386@yahoo.com.ar> wrote:
On 08/28/2011 10:55 PM, Gerardo Exequiel Pozzi wrote:
Also unused packages removed. --- scripts/releng-chroot-manager | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/releng-chroot-manager b/scripts/releng-chroot-manager index 029e293..780946e 100755 --- a/scripts/releng-chroot-manager +++ b/scripts/releng-chroot-manager @@ -25,7 +25,7 @@ _install_archiso () {
if [ $action == recreate ] then - extrapkgs="syslinux vim mc base-devel git svn cvs pwgen mkinitcpio cdrkit squashfs-tools devtools mkinitcpio-nfs-utils nbd libui-sh" + extrapkgs="vim mc base-devel git svn cvs mkinitcpio squashfs-tools libisoburn devtools libui-sh"
mkdir -p /var/releng/ || die_error "could not create /var/releng/" mount | grep -q "/var/releng/chroot-$arch"&& die_error "Mountpoints still in place in $arch chroot. Cannot remove the chroot" oops, missed cc to arch-releng.
Imho "Update extrapkgs for transition to libisoburn in archiso" and "Remove unused packages" should be separate commits. Even more, can you explain why each removed package is no longer needed? maybe put that in the commit message as well.
Dieter
To avoid git pollution like you said some times, but seems that here is not applicable. syslinux was used for isohybrid cdrkit was used for mkisofs mkinitcpio-nfs-utils was used for older mkinitcpio that -b does not work propertly, needed for archiso_pxe_nbd nbd was used for older mkinitcpio that -b does not work propertly, needed for archiso_pxe_nbd pwgen was used by mkarchiso/Makefile in ages were iso label was ARCH_ramdomchars (about two years ago) -- Gerardo Exequiel Pozzi \cos^2\alpha + \sin^2\alpha = 1
On Mon, 29 Aug 2011 11:46:49 -0300 Gerardo Exequiel Pozzi <vmlinuz386@yahoo.com.ar> wrote:
On 08/29/2011 10:25 AM, Dieter Plaetinck wrote:
Imho "Update extrapkgs for transition to libisoburn in archiso" and "Remove unused packages" should be separate commits. Even more, can you explain why each removed package is no longer needed? maybe put that in the commit message as well.
Dieter
To avoid git pollution like you said some times, but seems that here is not applicable.
All I want is that each commit represents a (one) logical change. Sometimes that means squashing several changes together if they belong to the same logical change, yielding a big commit, sometimes it means splitting up a small commit into two ever smaller ones if the changes are unrelated (like this case).
syslinux was used for isohybrid cdrkit was used for mkisofs mkinitcpio-nfs-utils was used for older mkinitcpio that -b does not work propertly, needed for archiso_pxe_nbd nbd was used for older mkinitcpio that -b does not work propertly, needed for archiso_pxe_nbd pwgen was used by mkarchiso/Makefile in ages were iso label was ARCH_ramdomchars (about two years ago)
thanks, now I understand. please put this also in the commit message. Of course, if packages were removed because they are no longer needed with the new libisoburn method, they should also go in the "Update extrapkgs for transition to libisoburn in archiso" commit (cdrkit). All removals of unused packages (with the exception of packages being removed because of the switch to libisoburn) can than be in a separate commit. Btw we still use isohybrid right? Than why is syslinux removed? Dieter
On 08/29/2011 12:41 PM, Dieter Plaetinck wrote:
Btw we still use isohybrid right? Than why is syslinux removed?
Dieter
No, this feature is integrated in xorrriso. + -isohybrid-mbr ${work_dir}/iso/isolinux/isohdpfx.bin \ The only thing needed here is the .bin from syslinux that is located on root-image. + cp ${work_dir}/root-image/usr/lib/syslinux/isohdpfx.bin ${work_dir}/iso/isolinux/ -- Gerardo Exequiel Pozzi \cos^2\alpha + \sin^2\alpha = 1
participants (2)
-
Dieter Plaetinck
-
Gerardo Exequiel Pozzi