[aur-dev] [PATCH] Change File Request To Submit a Request
It looks like my last attempt to post this here failed, so I am trying again. Ignore this if the first one appears. Here is a patch that makes it Submit a Request. I believe I also got the strings in the translation files. Mark Weiman
Here is a patch that makes it Submit a Request. I believe I also got the strings in the translation files.
Excellent work, Mark. I haven't checked it for correctness; I'll leave that to someone more knowledgeable (like Johannes, when he gets time). Regardless, I'm a very happy camper right now. I must admit, I really wasn't expecting you to come through like this. It's nice of you to do me (and the other Archers) a favor, especially after the "flame war" we had in the "aur-general" thread. I think the main reason you didn't find "File Request" at all confusing is that they don't use "lodge" where you are. As the latter is preferred in my area, I had to do a double-take whenever I saw the former.
On Wed, 25 Nov 2015 at 03:26:03, Mark Weiman wrote:
It looks like my last attempt to post this here failed, so I am trying again. Ignore this if the first one appears.
Here is a patch that makes it Submit a Request. I believe I also got the strings in the translation files. [...]
Great, thanks for the patch! It needs some polishing before it can be applied, though... * Please resubmit the patch inline (using git-send-email(1)) such that we can easily comment on specific parts. Commenting without any reference (like this) makes life harder for both the reviewer and the patch submitter. * Change the commit message such that the subject line is <50 characters long (something like 'Reword "File Request"'?) and the details are mentioned in the message body. We usually write "Fixes FS#47167." when a commit fixes a bug, though it is not a must. Also, a sign-off is missing. * Please drop all changes to the translation files. They are usually only updated before a new release is tagged. * You also changed the title of the "File Request" page and the label of the submit button on the "File Request" page. I am not sure about the former but I think the latter is not a good idea. It should either keep saying "File Request" or be changed to "Submit Request". If we decide to change it, maybe using "Submit Request" everywhere makes sense because then we wouldn't need to translate two strings meaning the same thing. Regards, Lukas
participants (3)
-
Lukas Fleischer
-
Mark Weiman
-
Xavion